I think it was just the push buttons themselves that were bad. I had the analogs soaking in vinegar to clean them and I guess I should have actively dried them as opposed to just drying out in my window sill. They were still clicky though, that's why I thought I had done something wrong with the wiring. Is that something I could have confirmed with the multimeter?
So I ordered some new analog modules for the board and it turns out my wiring was sound. I definitely agree though that my soldering needed improvement and the leads were atrocious on those wires, so I redid most of it. Also it was impossible to preserve the old the analogs as they were integrated into the rest of the module. It's difficult to explain, but for anyone attempting to mod this controller, try and maintain all the original parts as they very much proprietary in some respects.
I couldn't find thumbsticks for these particular analogs. They are labelled RSF and are smaller than the ALPS modules so conventional thumbsticks don't fit. I guess Microsoft has a monopoly on ALPS stock as far as controllers go. That's probably why all third party controllers are doomed from the start. The RSF sticks aren't *bad* but they certainly don't have the even tension of the ALPS modules (that's probably why the tension control idea was dreamed up in the first place.) I think this controller could have shone if Razer had used ALPS. I really like Razer and their products and am really impressed with this quality of the controller overall, especially when it was priced cheaper than its Microsoft counterpart. Razer also has great customer service, and replaced my controller outside of its year warranty. Microsoft would not do the same with a controller I had
for four months. :/
So since I was almost successful with this one, I took my other Razer controller and opened it to perform the same modifications:
Unfortunately the wires were brittle on the cord and they broke off while I was fiddling with the controller. I really didn't want to remove that black epoxy again without a fume extractor. I really couldn't get it off without melting it and letting it crystalize and then scraping it off. It has a very unpleasant smell. So I affixed a USB cable I extracted from a Chinese knock-off PnC and that worked just fine.
Everything went back together and the controller functions as it did before, with the controls reversed of course. One small problem is sometimes the left trigger actuates when the left analog is rotated. I assume it is too much analog voltage? Additionally the LSC actuates randomly, but this seems to be only when the controller is idle. Any suggestions?